Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove removed Debug/getDebugChainHeads V1 #4970

Merged
merged 2 commits into from
Jun 10, 2023
Merged

remove removed Debug/getDebugChainHeads V1 #4970

merged 2 commits into from
Jun 10, 2023

Conversation

tersec
Copy link
Contributor

@tersec tersec commented May 17, 2023

@github-actions
Copy link

Unit Test Results

         9 files  +       3    1 065 suites  +358   28m 51s ⏱️ + 8m 28s
  3 679 tests ±       0    3 400 ✔️ ±       0  279 💤 ±  0  0 ±0 
15 640 runs  +5 228  15 335 ✔️ +5 207  305 💤 +21  0 ±0 

Results for commit 0d9235f. ± Comparison against base commit 74511f6.

@zah
Copy link
Contributor

zah commented May 19, 2023

Previously, we've discussed that the best possible way to remove deprecated endpoints is to replace their implementation with an informative error message.

@tersec
Copy link
Contributor Author

tersec commented May 19, 2023

Previously, we've discussed that the best possible way to remove deprecated endpoints is to replace their implementation with an informative error message.

Considered that. This is in the debug namespace. While that's been abused for useful things such as getState, which probably shouldn't have been in this namespace to begin with, in general, trying to comply with more usual the meaning of that as, actually being a commitment to something "less" than the beacon/validator/etc namespaces (otherwise, what's the point).

That's kind of the deal with these namespaces: easier to add, easier to change, easier to remove.

So don't strongly oppose it in this case, but it's not the default I'd go with for the debug namespace.

@zah
Copy link
Contributor

zah commented May 23, 2023

It's very cheap to add the suggested error message and there aren't any downsides as far as I can tell.

@tersec tersec merged commit 6ebcbbd into unstable Jun 10, 2023
@tersec tersec deleted the 3jA branch June 10, 2023 08:07
@tersec tersec restored the 3jA branch June 10, 2023 08:07
@tersec tersec deleted the 3jA branch June 10, 2023 08:07
@tersec tersec restored the 3jA branch June 10, 2023 08:07
tersec added a commit that referenced this pull request Jun 10, 2023
tersec added a commit that referenced this pull request Jun 10, 2023
@tersec tersec deleted the 3jA branch June 10, 2023 08:09
@tersec
Copy link
Contributor Author

tersec commented Jun 10, 2023

This was accidentally merged, rather than updated/rebased to current unstable -- thus also did revert commit in unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants