Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower ClientMaximumValidatorIds to match beacon spec limit #5082

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Lower ClientMaximumValidatorIds to match beacon spec limit #5082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions beacon_chain/spec/eth2_apis/rest_types.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,10 @@ const
# will return HTTP error 400.
ServerMaximumValidatorIds* = 16384

# https://github.com/ethereum/beacon-APIs/blob/2.3.x/apis/beacon/states/validators.yaml#L23
# Maximum number of validators that can be sent in single request by
# validator client (VC).
# NOTE: This value depend on beacon node's `rest-max-headers-size`
# configuration option.
#
# Size of public key in HTTP request could be calculated by formula -
# bytes48 * 2 + len("0x") + len(",") = 99 bytes.
# So 1024 keys will occupy 101,376 bytes. Default value for HTTP headers size
# is 128Kb = 131,072 bytes.
ClientMaximumValidatorIds* = 1024
ClientMaximumValidatorIds* = 30

# https://github.com/ethereum/beacon-APIs/blob/master/apis/validator/duties/attester.yaml#L32
# https://github.com/ethereum/beacon-APIs/blob/master/apis/validator/duties/sync.yaml#L16
Expand Down