align style when calling LC libp2p API

[etan-status]

The UpdatesByRange API takes startPeriod / count, but is internally called by Slice. Move the logic that converts from the Slice to the caller to reduce complexity inside the used doRequest function.

[tersec]

Jenkins CI issues are due to

{"lvl":"FAT","ts":"2023-06-20 17:43:09.598+03:00","msg":"Low sync committee participation","topics":"chaindag","slot":3,"num_active_participants":338}

because #5082 and #5085 interact so that

$ grep -E "Validator indices updated|Producing sync committee messages.*slot=1 " *.jsonl
nimbus_validator_client.1.jsonl:INF 2023-06-20 10:51:22.446+01:00 Validator indices updated                  pending=224 missing=8 updated=30 service=duties_service
nimbus_validator_client.1.jsonl:INF 2023-06-20 10:51:34.031+01:00 Validator indices updated                  pending=194 missing=7 updated=30 service=duties_service
nimbus_validator_client.1.jsonl:INF 2023-06-20 10:51:46.073+01:00 Validator indices updated                  pending=164 missing=6 updated=30 service=duties_service
nimbus_validator_client.1.jsonl:INF 2023-06-20 10:51:58.105+01:00 Validator indices updated                  pending=134 missing=5 updated=30 service=duties_service
nimbus_validator_client.1.jsonl:DBG 2023-06-20 10:52:02.002+01:00 Producing sync committee messages          delay=2ms777us slot=1 duties_count=32 service=sync_committee_service
nimbus_validator_client.2.jsonl:INF 2023-06-20 10:51:23.724+01:00 Validator indices updated                  pending=224 missing=8 updated=30 service=duties_service
nimbus_validator_client.2.jsonl:INF 2023-06-20 10:51:34.031+01:00 Validator indices updated                  pending=194 missing=7 updated=30 service=duties_service
nimbus_validator_client.2.jsonl:INF 2023-06-20 10:51:46.073+01:00 Validator indices updated                  pending=164 missing=6 updated=30 service=duties_service
nimbus_validator_client.2.jsonl:INF 2023-06-20 10:51:58.071+01:00 Validator indices updated                  pending=134 missing=5 updated=30 service=duties_service
nimbus_validator_client.2.jsonl:DBG 2023-06-20 10:52:02.002+01:00 Producing sync committee messages          delay=2ms718us slot=1 duties_count=31 service=sync_committee_service
nimbus_validator_client.2.jsonl:INF 2023-06-20 10:52:10.065+01:00 Validator indices updated                  pending=104 missing=4 updated=30 service=duties_service

i.e. of the 512 sync committee validators, on average, all the BN-attached validators (EV: 256) and EV ~30*2, for EV of 316 validators < 2/3 * 512 = 341 supermajority requirement are there by slot 1, which trips this strictVerification.

#5105 is supposed to fix this.

[etan-status]

Oh, cool. Seems like #5085 has unearthed quite a few different things.