Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unplumbing Bellatrix builder API support #5203

Merged
merged 1 commit into from
Aug 5, 2023
Merged

unplumbing Bellatrix builder API support #5203

merged 1 commit into from
Aug 5, 2023

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Jul 20, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Unit Test Results

         9 files  +       3    1 077 suites  +362   39m 27s ⏱️ + 10m 32s
  3 723 tests ±       0    3 444 ✔️ ±       0  279 💤 ±  0  0 ±0 
15 874 runs  +5 306  15 569 ✔️ +5 285  305 💤 +21  0 ±0 

Results for commit af18a06. ± Comparison against base commit 706ce01.

♻️ This comment has been updated with latest results.

@tersec tersec force-pushed the 46T branch 3 times, most recently from 493306d to ac29606 Compare July 31, 2023 06:11
@tersec tersec enabled auto-merge (squash) July 31, 2023 06:49
@tersec tersec disabled auto-merge July 31, 2023 06:50
@tersec
Copy link
Contributor Author

tersec commented Jul 31, 2023

Even after #5223 https://ci.status.im/blue/organizations/jenkins/nimbus-eth2%2Fplatforms%2Fmacos%2Faarch64/detail/PR-5203/7/pipeline hits the ListKeys issue

[Suite] saveKeystore()
  [OK] Save [LOCAL] keystore after [LOCAL] keystore with same id
  [OK] Save [REMOTE] keystore after [REMOTE] keystore with same id
  [OK] Save [REMOTE] keystore after [LOCAL] keystore with same id
  [OK] Save [LOCAL] keystore after [REMOTE] keystore with same id
  [OK] Save [LOCAL] keystore after [LOCAL] keystore with different id
  [OK] Save [REMOTE] keystore after [REMOTE] keystore with different id
  [OK] Save [LOCAL] keystore after [REMOTE] keystore with different id
  [OK] Save [REMOTE] keystore after [LOCAL] keystore with different id

Wrote test_keymanager_api/bootstrap_node.enr

[Suite] Serialization/deserialization [Beacon Node] [Preset: mainnet]
  [OK] Deserialization test vectors

[Suite] ListKeys requests [Beacon Node] [Preset: mainnet]
vendor/nim-libp2p/libp2p/stream/bufferstream.nim(607) main
vendor/nim-libp2p/libp2p/stream/bufferstream.nim(597) NimMain
vendor/nim-libp2p/libp2p/stream/bufferstream.nim(588) PreMain
tests/test_keymanager_api.nim(1495) vendor/nim-testutils/testutils/unittests.nim
tests/test_keymanager_api.nim(1473) main
vendor/nim-chronos/chronos/asyncloop.nim(318) futureContinue
...

so it's at least more complicated

@tersec tersec enabled auto-merge (squash) August 5, 2023 02:36
@tersec tersec merged commit 1f5dd83 into unstable Aug 5, 2023
@tersec tersec deleted the 46T branch August 5, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant