Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST: Add implementation of postStateValidators and postStateValidatorBalances. #5632

Merged
merged 7 commits into from
Nov 29, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments.
Fix toList() issue.
cheatfate committed Nov 28, 2023
commit d60caf654dd3b4a0534cb12382884d1dc0b1ffd9
4 changes: 2 additions & 2 deletions beacon_chain/rpc/rest_constants.nim
Original file line number Diff line number Diff line change
@@ -25,9 +25,9 @@ const
BlockNotFoundError* =
"Block header/data has not been found"
EmptyRequestBodyError* =
"Empty request's body"
"Empty request body"
InvalidRequestBodyError* =
"Invalid request's body"
"Invalid request body"
InvalidBlockObjectError* =
"Unable to decode block object(s)"
InvalidAttestationObjectError* =
8 changes: 4 additions & 4 deletions beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim
Original file line number Diff line number Diff line change
@@ -3773,16 +3773,16 @@ proc toList*(value: set[ValidatorFilterKind]): seq[string] =
res: seq[string]
v = value

if pendingSet * v != {}:
if pendingSet * v == pendingSet:
tersec marked this conversation as resolved.
Show resolved Hide resolved
res.add("pending")
v.excl(pendingSet)
if activeSet * v != {}:
if activeSet * v == activeSet:
res.add("active")
v.excl(activeSet)
if exitedSet * v != {}:
if exitedSet * v == exitedSet:
res.add("exited")
v.excl(exitedSet)
if withdrawSet * v != {}:
if withdrawSet * v == withdrawSet:
res.add("withdrawal")
v.excl(withdrawSet)