New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VC: Use produceBlockV3 when its available. #5842

Merged

tersec merged 3 commits into unstable from vc-use-produceV3

Feb 2, 2024

Contributor

cheatfate commented Jan 30, 2024

No description provided.

cheatfate added 2 commits

January 29, 2024 05:52


          Initial commit.

7f41b9e


          Add helper functions and publishBlock() implementations.

beca1a0

github-actions bot commented Jan 30, 2024 •

edited

Loading

Unit Test Results

        9 files   1 104 suites 27m 43s ⏱️
  4 229 tests   3 882 ✔️ 347 💤 0 ❌
16 882 runs 16 484 ✔️ 398 💤 0 ❌

Results for commit e3ec481.

♻️ This comment has been updated with latest results.

tersec reviewed

View reviewed changes

beacon_chain/validator_client/common.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/validator_client/common.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/validator_client/block_service.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/forks.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/validator_client/block_service.nim Show resolved Hide resolved


          Address review comments.

e3ec481

tersec approved these changes

View reviewed changes

tersec merged commit 21efe7e into unstable

11 checks passed

tersec deleted the vc-use-produceV3 branch

February 2, 2024 15:24

tersec mentioned this pull request

rm spec-deprecated produceBlindedBlock REST API support #5644

Closed

etan-status added a commit that referenced this pull request


          fix Eth-Consensus-Block-Value reading

a4338e7

Fix regression from #5842 where `Eth-Execution-Payload-Value` is parsed
into `consensusValue` instead of `Eth-consensus-Block-Value`. We don't
use those values for now, but fixing avoids hard-to-debug bugs later.

etan-status mentioned this pull request

fix Eth-Consensus-Block-Value reading #5964

Merged

arnetheduck pushed a commit that referenced this pull request


          fix Eth-Consensus-Block-Value reading (#5964)

00510a9

Fix regression from #5842 where `Eth-Execution-Payload-Value` is parsed
into `consensusValue` instead of `Eth-consensus-Block-Value`. We don't
use those values for now, but fixing avoids hard-to-debug bugs later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet