remove MIRACL Core support #5941
Conversation
EIP-4844 requires BLST via `nim-kzg4844`; MIRACL Core is not supported. Therefore, remove support for the MIRACL Core backend. - status-im/nim-blscurve#170
| @@ -13,9 +13,9 @@ Example: secp256k1 | |||
|
|
|||
| ### Compiling directly the C files | |||
|
|
|||
| Example: MIRACL Core | |||
| Example: zlib | |||
There was a problem hiding this comment.
In general, this is covered by https://status-im.github.io/nim-style-guide/interop.c.html
There was a problem hiding this comment.
Yeah, the links were not frozen to a permalink. Besides switching to a different lib, the alternatives would be to keep it at MIRACL Core, but refer to a commit that's not a dead link, or to remove the handbook?
There was a problem hiding this comment.
Well, the point of the decision we made before was to stop maintaining the auditor's guide altogether. That should be complete.
Between that and removing the guide, if it's that bad to have some dead links (this will not be the only one), then yes, I'd suggest just removing the auditors handbook entirely.
There was a problem hiding this comment.
The auditor handbook can just have a warning to say that it's accurate as of July 2020.
It's still useful to point people new to nim to its security features as it's often something people ask.
I suggest linking to a permalink.
EIP-4844 requires BLST via
nim-kzg4844; MIRACL Core is not supported. Therefore, remove support for the MIRACL Core backend.