-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/update libp2p branch master #6253
Conversation
|
Oh sorry, I missed that. Fixed. |
Lint failure is
This is triggered by nimbus-eth2/.github/workflows/ci.yml Lines 293 to 297 in 1ab6f16
Need to update
whereas as it notes, the most recent |
@@ -24,7 +24,7 @@ | |||
path = vendor/nim-libp2p | |||
url = https://github.com/vacp2p/nim-libp2p.git | |||
ignore = untracked | |||
branch = unstable | |||
branch = master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not pointing to the default branch, but instead to the one that should be used for building. If we should no longer use unstable version of libp2p, have to checkout a different ref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the intent; the vacuous bump there now enforces/ensures this gets picked up by git
. libp2p is switching from unstable
to master
for this purpose. Before master
hadn't been updating enough to make it worthwhile; now it will.
I added an empty commit to libp2p and did a dummy-bump in the latest commit of this PR. |
changes the default branch of libp2p from unstable to master.
See vacp2p/nim-libp2p#1088