Add publishAggregateAndProofsV2 #6546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Sep 12, 2024
tersec
reviewed
Sep 13, 2024
tersec
reviewed
Sep 13, 2024
tersec
reviewed
Sep 13, 2024
|
|
||
| var proofs: seq[Future[SendResult]] | ||
| template addDecodedProofs(ProofType: untyped) = | ||
| let dres = decodeBody(seq[ProofType], contentBody.get()) |
There was a problem hiding this comment.
Should use 2 space indentation instead of 4 for template body
tersec
reviewed
Sep 13, 2024
| let dres = decodeBody(seq[ProofType], contentBody.get()) | ||
| if dres.isErr(): | ||
| return RestApiResponse.jsonError(Http400, | ||
| InvalidAggregateAndProofObjectError, |
There was a problem hiding this comment.
Probably more consistent to indent InvalidAggregateAndProofObjectError and $dres.error() with Http400, rather than (Http400,, i.e. one space more. it's what you do later in the same function (AggregateAndProofValidationError) at least, and what most of this module uses.
|
https://github.com/status-im/nimbus-eth2/actions/runs/10853866443/job/30123076903?pr=6546 from probably unrelated to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new endpoint version(v2) for validator aggregate and proof.
spec: ethereum/beacon-APIs/pull/456