Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Nimble hash for new Nim version #6797

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

crStiv
Copy link

@crStiv crStiv commented Dec 26, 2024

Changes

  • Updated Nimble hash in nix/nimble.nix to match current Nim version
  • Added CI workflow to automatically verify hash when nimble.nix is modified

Details

  • Fixed incorrect hash in nix/nimble.nix:
    -   hash = "sha256-sa0irAZjQRZLduEMBPf7sHlY1FigBJTR/vIH4ihii/w=";
    +   hash = "sha256-MVHf19UbOWk8Zba2scj06PxdYYOJA6OXrVyDQ9Ku6Us=";
  • Added new workflow .github/workflows/check-nim-hash.yml for automatic hash verification on future updates

Related issues

Fixes #6765

Testing

  • Verified locally using nix-build nix/nimble.nix
  • CI workflow successfully verifies hash correctness

@tersec
Copy link
Contributor

tersec commented Dec 26, 2024

Overtaken by events: #6795

@crStiv
Copy link
Author

crStiv commented Dec 26, 2024

Overtaken by events: #6795

but why the issue still opened then?

@tersec
Copy link
Contributor

tersec commented Dec 27, 2024

Overtaken by events: #6795

but why the issue still opened then?

  1. it is closed now by the issue reporter
  2. I asked the issue reporter, in said issue where it was publicly visible, if the Nim 2.0.14 PR fixed it for them five hours before you opened this PR
  3. that said, your .github/workflows/check-nim-hash.yml workflow is interesting, but probably not how we'd prefer to have such functionality. in theory https://github.com/status-im/nimbus-eth2/blob/unstable/ci/nix.Jenkinsfile already should have caught this -- the question is why it didn't. I suspect it's related to Nix's package caching by hash and that it might need to clear that cache first, otherwise it doesn't bother downloading Nimble from GitHub at all.

@jakubgs
Copy link
Member

jakubgs commented Jan 2, 2025

Fixed in alongside some other Nix related issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants