chore: identify version numbers using a git tag #16652
Draft
+49
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
force-pushed
the
12349-wrong-version-displayed-in-night-builds
branch
from
515e09d
to
1eb40e4
Compare
Jenkins BuildsClick to see older builds (1)
|
caybro
force-pushed
the
12349-wrong-version-displayed-in-night-builds
branch
from
1eb40e4
to
e47afa7
Compare
- remove VERSION file - expose the `GIT_COMMIT`so that we can properly construct the web links when the user clicks the version number in Settings/About - some smaller cleanups and warning fixes Fixes #12349
caybro
force-pushed
the
12349-wrong-version-displayed-in-night-builds
branch
from
e47afa7
to
bb4881e
Compare
|
@yakimant hi, will need a little help here: it seems like Jenkins is relying some checks on the existence of the VERSION file. The goal of this PR is to get rid of it, and use the git tags only to identify the version number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #12349
Affected areas
Settings/About, version number
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Local build:
