-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Onboarding): Create Profile & Login flows #16722
Open
caybro
wants to merge
3
commits into
master
Choose a base branch
from
feat/onboarding-rework-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,061
−343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (322)
|
caybro
force-pushed
the
feat/onboarding-rework-1
branch
26 times, most recently
from
November 13, 2024 19:39
fe0f177
to
315bbc0
Compare
caybro
force-pushed
the
feat/onboarding-rework-1
branch
2 times, most recently
from
November 14, 2024 16:51
ad67a76
to
35e9ad5
Compare
caybro
changed the title
feat(Onboarding): Create Profile
feat(Onboarding): Create Profile flows
Nov 20, 2024
caybro
requested review from
Khushboo-dev-cpp
and removed request for
a team and
Khushboo-dev-cpp
November 20, 2024 14:52
caybro
force-pushed
the
feat/onboarding-rework-1
branch
from
November 22, 2024 10:51
69cc5d5
to
72278e2
Compare
caybro
changed the title
feat(Onboarding): Create Profile flows
feat(Onboarding): Create Profile & Login flows
Nov 22, 2024
caybro
force-pushed
the
feat/onboarding-rework-1
branch
2 times, most recently
from
November 22, 2024 16:56
0cf6e77
to
9c4479f
Compare
caybro
requested review from
antdanchenko
and removed request for
a team and
antdanchenko
November 22, 2024 16:56
caybro
force-pushed
the
feat/onboarding-rework-1
branch
3 times, most recently
from
November 26, 2024 01:13
7fd1dbc
to
2316ade
Compare
anastasiyaig
force-pushed
the
feat/onboarding-rework-1
branch
from
November 26, 2024 06:24
4a5758f
to
4a0446b
Compare
i found one more place affected by this change, its not in critical path but i would like to fix it in this pr if time permits (should be today) |
anastasiyaig
force-pushed
the
feat/onboarding-rework-1
branch
from
November 26, 2024 16:41
4a0446b
to
c13d622
Compare
done! |
anastasiyaig
approved these changes
Nov 26, 2024
- implement the basic Onboarding UI skeleton and the Create Profile flows - adjust the PasswordView and EnterSeedPhrase views to the latest design - add the main OnboardingLayout and StatusPinInput pages to Storybook - change terminology app-wide: "Seed phrase" -> "Recovery phrase" Fixes #16719 Fixes #16742 Fixes #16743
- implement the Login flows (seed, sync, keycard) - amend the keycard flow sequences with separate (non) empty page
caybro
force-pushed
the
feat/onboarding-rework-1
branch
from
November 27, 2024 11:19
c13d622
to
51c8953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Create profile UI flows:
Fixes #16719
Fixes #16742
Fixes #16743
Login UI flows:
Fixes #16798
Fixes #16799
Fixes #16800
Affected areas
Onboarding
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)