Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContactDetails decomposed into smaller, more specialized components #16794

Open
wants to merge 1 commit into
base: refactor/users-models
Choose a base branch
from
Open

ContactDetails decomposed into smaller, more specialized components #16794

wants to merge 1 commit into from
+475 −877

Conversation

micieslak
Copy link
Member

@micieslak micieslak commented Nov 21, 2024 •
edited
Loading

What does the PR do

Decomposes original ContactDetails into more specialized components that can be used together or separately, depending on the needs/context:

  • ContactDetails - plain container for data (to aggregate all contact details properties into single entity)
  • AllContactsAdaptor - adaptor which allows to add self contact to arbitrary model of contacts
  • ContactModelEntry - wraps ModelEntry to expose contact entry in a convenient, type-safe way

Moreover:

  • ProfileDialogView simplification - no need to handle dirty values in a special way, dirty/dirtyValues properties removed
  • ProfileDialogView takes only contact details, caller can decide how to provide it

Closes: #16793

Depends on: #16667

Affected areas

mainly: ContactDetails, ProfileDialogView

Architecture compliance

@micieslak micieslak requested review from caybro, alexjba and a team as code owners November 21, 2024 15:27
@status-im-auto
Copy link
Member

status-im-auto commented Nov 21, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a2bdcfb #1 2024-11-21 15:34:40 ~7 min macos/aarch64 🍎dmg
✔️ a2bdcfb #1 2024-11-21 15:35:55 ~8 min tests/nim 📄log
✔️ a2bdcfb #1 2024-11-21 15:39:57 ~12 min tests/ui 📄log
✔️ a2bdcfb #1 2024-11-21 15:43:49 ~16 min linux-nix/x86_64 📦tgz
✔️ a2bdcfb #1 2024-11-21 15:45:43 ~18 min linux/x86_64 📦tgz
✔️ a2bdcfb #1 2024-11-21 15:55:16 ~27 min windows/x86_64 💿exe
✔️ a2bdcfb #1 2024-11-21 15:56:23 ~28 min macos/x86_64 🍎dmg

caybro
caybro reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one question :)

ui/app/mainui/adaptors/AllContactsAdaptor.qml Show resolved Hide resolved
alexjba
alexjba approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

caybro
caybro approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjba alexjba alexjba approved these changes

@caybro caybro caybro approved these changes

@jrainville jrainville Awaiting requested review from jrainville

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micieslak @status-im-auto @caybro @alexjba