feat: status-go API logging option #16808
Open
+29
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
requested review from
richard-ramos,
a team,
antdanchenko,
jrainville and
anastasiyaig
and removed request for
a team and
richard-ramos
igor-sirotin
changed the title
Jenkins BuildsClick to see older builds (15)
|
|
hey @igor-sirotin , thanks for that PR sadly i could not see any api.log file anywhere, neither for dev build nor for local build. I run the app for the packaged build like this: I also added mentioned env var, but not sure, shall it have any value? tried with Also I tried with local build by using this command: 
|
anastasiyaig
force-pushed
the
feat/statusgo-api-log
branch
from
ba08230
to
bb046a8
Compare
|
@anastasiyaig indeed, sorry for that. Looks like I missed to bump |
|
alright it works to me now, thanks @igor-sirotin |
anastasiyaig
approved these changes
Nov 25, 2024
jrainville
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16414
Requires:
InitializeApplicationstatus-go#6117What does the PR do
Added ability to enable
status-goAPI logging. Run with--api-loggingor env varSTATUS_RUNTIME_API_LOGGING=1.The log will appear in
<account>/data/api.logfile.Also added proper initialization of logging in status-go.
Before this PR logs would appear in
geth.logfile only after logging into account, and before logging it it was in in console.Now all logs go into the file right from the start.
Affected areas
Logging, initialize application
Risk
Described potential risks and worst case scenarios.
Tick one: