handle larger messages #531
Conversation
🦋 Changeset detectedLatest commit: c5501e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@felicio is attempting to deploy a commit to the Status Team on Vercel. A member of the Team first needs to authorize it. |
|
note: addressing #529 (comment) |
|
relates: status-im/status-go#4922 |
| let decodedMetadata | ||
| try { | ||
| decodedMetadata = ApplicationMetadataMessage.fromBinary(messageToDecode) | ||
| } catch { | ||
| return | ||
| } | ||
|
|
||
| if (!decodedMetadata.payload) { | ||
| return | ||
| } | ||
|
|
||
| if (!decodedMetadata.signature.length) { | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Overall, I think the code is a bit verbose and makes it harder to read and maintain. Maybe joining these conditions will help a bit.
if (!decodedMetadata || !decodedMetadata.payload || !decodedMetadata.signature.length) {
return;
}Also i see you're not handling the error. Wouldn't you use it somehow in this case?
There was a problem hiding this comment.
In the current context, it's an invalid message that's worth skipping, I believe. I do think it's worth monitoring invalid messages, their size and rate but on anohter level, I'd say.
No description provided.