Enable setting the default RSA keysize using swtpm_setup.conf #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor-out read_file_lines from get_default_pcr_banks and pass the array of lines from the config file into get_default_pcr_banks now. Now other functions will also be able to access the lines from the config file without having to re-read the config file. Signed-off-by: Stefan Berger <[email protected]>
If the user did not provide the RSA keysize to use try to read it from setup_setup.conf and if nothing is found there fall back to using the internal default RSA keysize (2048). Signed-off-by: Stefan Berger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to provide a default RSA keysize using swtpm_setup.conf. It is used unless the user provided it with command line option to swtpm_setup.