This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
zkvm: implement and
, or
, verify
instructions
#147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleganza
reviewed
Feb 27, 2019
oleganza
reviewed
Feb 27, 2019
oleganza
reviewed
Feb 27, 2019
oleganza
reviewed
Feb 27, 2019
oleganza
reviewed
Feb 27, 2019
oleganza
reviewed
Feb 27, 2019
cathieyun
force-pushed
the
cathie/opcodes
branch
from
February 27, 2019 23:20
f9c9239
to
8a7aab1
Compare
oleganza
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraint::{And, Or}
to be a tuple of two boxed constraints, instead of a vector (since they'll only ever be created from two constraints anyways, and we can do the flattening in theverify
functionand
,or
using the new Constraint typeverify
: enter 2nd phase of 2-phase challenge API, in order to getz
challenge. Then recursively "flatten" the constraint, until the base caseExpression
type, and combine theExpression
s according to the rules until you have oneExpression
that represents the whole constraint. Then push that constraint onto the constraint system.Question: I implemented the
From<R1CSError> for VMError
trait, but inverify
it does not automatically convertR1CSError
toVMError
, so I have to do it explicitly. I thought this would be implicit because of theFrom
trait?Update: What I'd want is
TryFrom
, which is nightly-only. So I'll just do explicit conversion for now!