-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soroban-rpc: refactor libpreflight #875
Conversation
Also, fix a couple of memory leaks on the way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that preflight.rs is independent, it would be great to add some unit tests (which could help show me which bugs you fixed, because right now I've no idea).
Good idea, I will do it in a separate PR though, although the memory leak bugs I fixed were in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments; overall looks great.
@paulbellamy PTAL |
preflight.rs
which contains the actual preflight computations, separate from theGo<->Rust
ffi interfacing (which is the only thing left inlib.rs
).anyhow
crate to:Result<R, Box<dyn Error>>
vsResult<R>
)free_preflight_result()