Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement conformance test binary #661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ralith
Copy link

@Ralith Ralith commented Dec 21, 2022

Implementation of the conformance test protocol defined at https://github.com/protocolbuffers/protobuf/tree/main/conformance.

@Ralith Ralith force-pushed the push-d961a3d6e69d4179ba27ba7cafc632e6 branch from 3f946df to 12a57ad Compare December 21, 2022 05:56
@Ralith Ralith force-pushed the push-d961a3d6e69d4179ba27ba7cafc632e6 branch from 12a57ad to be1cb07 Compare December 21, 2022 06:05
@Ralith Ralith marked this pull request as ready for review December 21, 2022 06:07
@Ralith
Copy link
Author

Ralith commented Dec 21, 2022

I think this is working now. It's found a bunch of failures when ran against the test suite from 3.21. Looks like a lot of unexpected successful parses (particularly around EoF handling), but also some panics and many cases of data failing to pass through. Haven't fully eliminated the possibility that the test is doing something wrong.
test-results.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant