Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms_tabNavigationEnabled not working #105

Closed
nubsoft opened this issue May 3, 2017 · 2 comments
Closed

ms_tabNavigationEnabled not working #105

nubsoft opened this issue May 3, 2017 · 2 comments
Assignees
Labels

Comments

@nubsoft
Copy link

nubsoft commented May 3, 2017

Hi, ms_tabNavigationEnabled=false not working , When I'm on tab number 2 , I still can click on tab number 1 and goes to that tab directly, which shouldn't be possible when ms_tabNavigationEnabled=false

<com.stepstone.stepper.StepperLayout
    android:id="@+id/stepperLayout"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical"
    app:ms_stepperType="tabs"
    app:ms_stepperFeedbackType="tabs|content|disabled_bottom_navigation"
    app:ms_tabNavigationEnabled="false"
    app:ms_backButtonText="Back"
    app:ms_nextButtonText="Next"
    app:ms_completeButtonText="END"/>```


 
@zawadz88 zawadz88 self-assigned this May 4, 2017
@zawadz88
Copy link
Contributor

zawadz88 commented May 4, 2017

Hi @nubsoft,
Thanks for reporting this! From what I can see it's an issue when ms_tabNavigationEnabled is used together with tabs stepper feedback and the issue is in TabsStepperFeedbackType#hideProgress where tab navigation is always enabled.
It should check first if this wasn't set to false.

I'll try to fix this, but as a temporary workaround you can call StepperLayout#setTabNavigationEnabled(false) after calling StepperLayout#hideProgress()

@zawadz88 zawadz88 added the bug label May 4, 2017
zawadz88 pushed a commit that referenced this issue May 4, 2017
…tabs' stepper feedback & disabled tab navigation attribute (issue #105).

* Updated Android Support Library to 25.3.1
* Updated library version to 3.2.1
zawadz88 pushed a commit that referenced this issue May 10, 2017
…tabs' stepper feedback & disabled tab navigation attribute (issue #105).

* Updated Android Support Library to 25.3.1
* Updated library version to 3.2.1
@zawadz88
Copy link
Contributor

This should be fixed in 3.2.1 now.
Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants