How does android:orientation work on the widget?

[tiagoalmeida92]

Had some problems I though it was not necessary, and nothing shows when it's horizontal.

[zawadz88]

Hi,
You shouldn't be using this attribute on this View. It works only in the vertical mode. If you look at ms_stepper_layout.xml you should see why nothing is shown.

What were you trying to achieve?

[tiagoalmeida92]

Oh I understand the view extends LinearLayout, I think it would be best if you force vertical orientation in code, otherwise other developers might forget to add the attribute in the xml.

Great lib thanks

[zawadz88]

Hi @tiagoalmeidagit,
This attribute shouldn't be needed at all when declaring a StepperLayout in your layout XML.
You're saying that if you don't specify it a horizontal orientation is used?

[tiagoalmeida92]

Yes,

in your getting started wiki the example has orientation vertical, I tried to remove it and had problems.

<com.stepstone.stepper.StepperLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/stepperLayout"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical"
app:ms_stepperType="progress_bar" />

[zawadz88]

Wow, I can't believe we actually missed it :P This is definitely a bug.
Thank you for reporting this!
That's something we definitely have to fix.

[zawadz88]

The changes are already on master and will be released in the upcoming patch release.
@tiagoalmeidagit again thank you for reporting this