Change order of initialization, fixes #1059 #1062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreiche
commented
Oct 18, 2024
mreiche
commented
stevehipwell
requested changes
Oct 21, 2024
The output above is from the tested container. I've updated the changelog but in the Unreleased section. Hope that fits. |
stevehipwell
requested changes
Oct 24, 2024
| @@ -14,6 +14,8 @@ | |||
|
|
|||
| ## [UNRELEASED] | |||
|
|
|||
| - Changed the order of the initialization scripts to allow creating roles based on repository privileges (fixes #1059) | |||
There was a problem hiding this comment.
Suggested change
| - Changed the order of the initialization scripts to allow creating roles based on repository privileges (fixes #1059) | |
| ### Changed | |
| - Changed the order of the initialization scripts to allow creating roles based on repository privileges. ([#1062](https://github.com/stevehipwell/helm-charts/pull/1062) _@mreiche_ |
If you want to reference the actual change this is the pattern to use.
|
@mreiche I'm having to do an emergency release of the chart so I'm going to make these changes directly. Thanks for your PR, FYI the scripts and cleanup blocks would also need moving up as repo config can refer to cleanup policies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.