Sets ConfigEntry.Default flag in addition to the ConfigEntry.Source f… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Kafka versions > V1_1_0_0 (#1594) * Set describeConfigsRequest.Version in ListTopics for consistency with DescribeConfig This breaks the output of ListTopics for newer request versions, it now includes default configuration settings. * Set ConfigEntry.Default for KafkaVersions > 0 Clients can now rely on the `Default` flag again and don't have to check the `Source` for higher Kafka versions. * Set ConfigEntry.Source to default for KafkaVersions <= 0 when applicable * Add tests for default flag/source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or Kafka versions > V1_1_0_0 (IBM#1594)
This breaks the output of ListTopics for newer request versions, it now includes default configuration settings.
Clients can now rely on the
Defaultflag again and don't have to check theSourcefor higher Kafka versions.Set ConfigEntry.Source to default for KafkaVersions <= 0 when applicable
Add tests for default flag/source