minor code cleanup (first attempt) #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhishkr
commented
Mar 4, 2018
| @@ -1,5 +1,3 @@ | |||
| import os | |||
|
|
|||
There was a problem hiding this comment.
cleaning up unused imports in the file
| @@ -40,7 +40,7 @@ def test_read_n_chars(self): | |||
|
|
|||
| self.assertEquals(self.reader.read(1), '') | |||
|
|
|||
| def test_read_n_chars(self): | |||
| def test_read_n_chars_2(self): | |||
There was a problem hiding this comment.
there were 2 tests with the same name, separating them as test_*_1 & test_*_2
| @@ -30,7 +30,7 @@ def test_read(self): | |||
| for index, x in enumerate(lines.split('\n')): | |||
| self.assertEquals(x, str(index)) | |||
|
|
|||
| def test_read_n_chars(self): | |||
| def test_read_n_chars_1(self): | |||
There was a problem hiding this comment.
there were 2 tests with the same name, separating them as test_*_1 & test_*_2
| @@ -3,7 +3,6 @@ | |||
| import boto.s3 | |||
| import boto.s3.connection | |||
| import boto.provider | |||
| import zipfile | |||
There was a problem hiding this comment.
cleaning up unused imports in the file
| @@ -96,7 +93,7 @@ def readline(self, limit=None): | |||
|
|
|||
| return line | |||
|
|
|||
| def readlines(self, sizehint=None): | |||
There was a problem hiding this comment.
cleaning up because : sizehint is unused
| @@ -87,7 +84,7 @@ def readline(self, limit=None): | |||
| else: | |||
| line += new_data | |||
|
|
|||
| if limit > 0 and len(line) == limit: | |||
| if 0 < limit == len(line): | |||
There was a problem hiding this comment.
shortening the chained comparison problem
|
|
||
| # IDE | ||
| .idea | ||
| .idea/* |
There was a problem hiding this comment.
i use pycharm for python work, just thought its good to have these in the .gitignore to avoid idea folder from getting checked in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TheDataChef @jeffmagnusson @drudd (pulled this list from frequent & recent committers to this repo)
first attempt at a minor code cleanup PR, have left comments on why I have removed / edited directly on the diffs to make it easier for you to read.