-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shamelessly copy DMA implementation from stm32f1xx-hal crate. #123
base: master
Are you sure you want to change the base?
Conversation
Very nice! Obviously needs some more work though. I'd probably split out the |
Good idea, I’ll make a separate PR for updating dependencies and have a look at the failing CI. |
bors try |
tryMerge conflict. |
Hi, the PR still doesn't pass CI as the f1xx-hal uses Removing he non_exhaustive attribute is not a problem, but it would break the cross HAL compatibility. |
I'm not a big fan of MSRV in general. Let's just bump the version in CI. |
Ok, I'll make the PR when I have time in a few days. Should I remove checking against some specific rust version in general or just bump the specified version to a current Rust version? What about the timing out bors? Do you have any idea why it fails? Fix for it could also be a part of that PR. |
f897726
to
7454fca
Compare
7454fca
to
70d0285
Compare
Any updates here? Can you add an example using DMA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please add a CHANGELOG entry and an example?
@therealprof Sorry for ignoring my PRs and you, I am a bit busy and don't develop on F0 often nowadays. I have the work on these PRs on my TODO list and will get back to them when I have a bit more time - unfortunately in June. |
No worries, I can totally relate. Busy times with unrelated things for me as well... |
This PR adds DMA interface created using embedded-dma traits, that was copied from the stm32f1xx-hal crate and adapted for the needs of STM32F0 controller line.
DMA2 for STM32F091 was not yet added as to my understanding it requires some special handling.