-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement interface to internal flash storage #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be used to read the flash size and device UID
- Interface is mostly copied and adapted from the F4-HAL - Hardfaults while programming flash
therealprof
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an interface to reading and writing to the internal flash memory. This implements the
NorFlash
traits from theembedded-storage
crate.The interface is inspired by the interfaces used in the
stm32f4xx-hal
and thestm32g0xx-hal
.The interface could definitely use some clean up and I'm open to suggestions on that matter. Especially the handling of writing to addresses not aligned to the native write size is something I'm not sure about. The
stm32g0xx-hal
has a different approach for this, but their approach has some problems in my opinion:0x08008001
) will lead to a panic due to the slice index being out of range.The reasons above are why i choose the approach of returning an Error instead of trying to pad the data into native writes.
I also provided a basic example of how to use the flash interface.
The CI checks of this PR will fail until #170 (or an alternative solution) is merged.