Improve build.rs and some more. #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sh3Rm4n
force-pushed
the
memory_x
branch
3 times, most recently
from
d6667de to
10c4e9f
Compare
Piroro-hs
suggested changes
Apr 30, 2021
|
How about changing those eprintln!(
"I've just found Rust's string literal support line breaking.\n\
\n\
We can keep indentation!!!."
); |
|
Oh, I've searched for a variation to keep the indentation as well. 😄 Thanks for the tip 👍 |
Sh3Rm4n
force-pushed
the
memory_x
branch
3 times, most recently
from
058f89d to
f59b652
Compare
Piroro-hs
reviewed
Apr 30, 2021
As we are now using build.rs to check the feature selection, we can now make more sophisticated checks. Therefor we use build.rs to compare the selected features and the features in the Cargo.toml (via cargo_metadata), and verify, that only a single valid device feature is selected.
And additional documentation improvments
Co-authored-by: Piroro-hs <[email protected]>
|
Thanks for your review @Piroro-hs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some ideas about the newly added build.rs and touched some documentation as well.
What do you think about this change, @Piroro-hs?