Support USB on the stm32f303xd/xe devices #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellmcc
force-pushed
the
feature/xd-xe-usb
branch
2 times, most recently
from
124bae5 to
ab61a1a
Compare
Sh3Rm4n
requested changes
Jul 13, 2021
russellmcc
force-pushed
the
feature/xd-xe-usb
branch
from
898889b to
ec77778
Compare
Sh3Rm4n
requested changes
Jul 14, 2021
The 303xd and 303xe series devices do not have AF14 for pins PA11 and PA12, so the existing implementation will not work for those devices. According to an ST document [1], stm32f303xd and xe do not require any particular mode for the PA11 and PA12 pin, so I've parameterized the `usb::Peripheral` type using traits so that any mode will be supported. I've tried to follow a familiar pattern reminescent of the gpio alternate function configurations. [1]: https://www.st.com/resource/en/application_note/dm00260340-migrating-between-stm32f303-and-stm32f302-line-products-stmicroelectronics.pdf
Co-authored-by: Fabian <[email protected]>
russellmcc
force-pushed
the
feature/xd-xe-usb
branch
from
ebadc98 to
f3046e3
Compare
Woops! No problem, thanks for all of your awesome work on this repo! |
russellmcc
force-pushed
the
feature/xd-xe-usb
branch
from
7144e89 to
003ea67
Compare
Sh3Rm4n
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 303xd and 303xe series devices do not have AF14 for pins PA11 and
PA12, so the existing implementation will not work for those devices.
According to an ST document 1, stm32f303xd and xe do not require any
particular mode for the PA11 and PA12 pin, so I've parameterized the
usb::Peripheraltype using traits so that any mode will besupported. I've tried to follow a familiar pattern reminescent of the
gpio alternate function configurations.
This is of course a breaking change so I'm open to other approaches if
anyone has opinions. This seemed to me to be the most elegant and
accurate way to handle this.