Minimal DAC driver #318
Merged
Minimal DAC driver #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to stm32-rs/stm32-rs
that referenced
this pull request
Jun 15, 2022
742: F302: rename `DAC` to `DAC1` r=richardeoin a=jonas-schievink This matches other chips in the F30x lineage and is also how the reference manual calls it. cc stm32-rs/stm32f3xx-hal#318, where the inconsistent name required some extra `#[cfg]`s Co-authored-by: Jonas Schievink <[email protected]>
|
Friendly ping @Sh3Rm4n :) |
|
Thanks! That's very much a minimal implementation. Wasn't aware that the implementation is so easy 😀 Sorry for the delay. With the addition of a CHANGELOG entry, this would be good to go! |
Sh3Rm4n
approved these changes
Aug 2, 2022
|
Thanks for the review! I've added a changelog entry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a minimal DAC driver that supports manual sample output on channel 1 only, and does not manage pins. I hope that's okay and you'll still consider merging this :)