Use gpio variants #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sh3Rm4n
force-pushed
the
gpio-variant
branch
from
f42f54e to
8098b58
Compare
Sh3Rm4n
force-pushed
the
gpio-variant
branch
4 times, most recently
from
f2c8bf6 to
0bc070b
Compare
|
Now that stm32f3 v0.10 is released, this builds for all stm3f3xx targets again. This blows up the macros in the gpio module to a large extent, but the code itself should be simplified. I would keep it like that for now. When the field array support is released under a new svd2rust version and stm32f3 will use it in the next release, this code could be simplified a lot. When this happens, i will open a follow up PR. |
|
Hey @Sh3Rm4n, could you rebase to resolve the conflicts? |
teskje
requested changes
Jul 15, 2020
stm32f3 provides methods, with which we can access each variant of a register. No more bit-shifts and -masks are needed. This also removes a lot off `unsafe` calls, which where needed before to access a whole register without any bound guards for fields and flags. This makes the macro section quite more verbose, because there is no method with an array index access-point. So we have to be explicit for every method name we add. `moder0`, `moder1`, ...
teskje
approved these changes
Jul 17, 2020
|
Looks good, thanks! |
teskje
added a commit
to teskje/stm32f3xx-hal
that referenced
this pull request
Jul 17, 2020
This commit: - Makes the order of InputPin impls consistent - Impls InputPin only for Output<OpenDrain>, not the generic Output<MODE> - Adjusts the register access in accordance with the recently merged GPIO refactoring (stm32-rs#42) - Makes rustfmt happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades to variant methods for the gpio module.
Doing this I had to extend the macro invocations significantly.
Also, I found no elegant way to apply this to the downgradable pins, as the pin register field access is determined via
"runtime".
rust-embedded/svd2rust#400 could help with that.
Also, for the
stm32f3x8andstm32f373series, this can not be applied right now, as they are missing a gpio documentation.stm32-rs/stm32-rs#321 will add these.