Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We can't rely on OS being what we expect, so set BUILD_HARNESS_OS ourselves #1

Merged
merged 1 commit into from
Feb 13, 2020
Merged

We can't rely on OS being what we expect, so set BUILD_HARNESS_OS ourselves #1

merged 1 commit into from
Feb 13, 2020

Conversation

schmidtd
Copy link

With OS being such a short name, collisions are easy to happen. Protect BUILD_HARNESS_OS by setting it explicitly.

@schmidtd schmidtd requested a review from Kyl-Bempah February 13, 2020 21:42
@schmidtd schmidtd changed the title We can't rely on OS being what we expect, so set it ourselves We can't rely on OS being what we expect, so set BUILD_HARNESS_OS ourselves Feb 13, 2020
Kyl-Bempah
Kyl-Bempah approved these changes Feb 13, 2020
View reviewed changes
Copy link

@Kyl-Bempah Kyl-Bempah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to eventually push this up to cloudposse, but will suffice for now.

@schmidtd schmidtd merged commit 49fc195 into master Feb 13, 2020
@schmidtd schmidtd deleted the protect_os_variable branch February 13, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyl-Bempah Kyl-Bempah Kyl-Bempah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmidtd @Kyl-Bempah