Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-10414] Updated Go version to 1.21 #227

Closed
wants to merge 3 commits into from

Conversation

dislbenn
Copy link
Contributor

@dislbenn dislbenn commented Mar 7, 2024

Description

Updating repository Go version to 1.21.

Related Issue

https://issues.redhat.com/browse/ACM-10414

Changes Made

Updated go version from 1.20 => 1.21.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Disaiah Bennett <[email protected]>
@dislbenn dislbenn changed the title Updated go version to 1.21 Updated Go version to 1.21 Mar 7, 2024
@openshift-ci openshift-ci bot added the approved PR approval has been given label Mar 7, 2024
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dislbenn
Copy link
Contributor Author

dislbenn commented Mar 7, 2024

/override "KinD tests (1.21, latest)"

Copy link

openshift-ci bot commented Mar 7, 2024

@dislbenn: Overrode contexts on behalf of dislbenn: KinD tests (1.21, latest)

In response to this:

/override "KinD tests (1.21, latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stolostron stolostron deleted a comment from openshift-ci bot Mar 7, 2024
@dislbenn dislbenn requested a review from ngraham20 March 12, 2024 17:42
@dislbenn dislbenn changed the title Updated Go version to 1.21 [ACM-10414] Updated Go version to 1.21 Mar 12, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@ngraham20 ngraham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dislbenn dislbenn closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants