Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-9339] Re-enabled clusters mgmt api #228

Closed
wants to merge 9 commits into from

Conversation

dislbenn
Copy link
Contributor

Description

Re-added clusters_mgmt API usage in discovery controller.

Related Issue

https://issues.redhat.com/browse/ACM-9339

Changes Made

Updated discovery controller to use clusters_mgmt API.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Disaiah Bennett <[email protected]>
Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved PR approval has been given label Mar 14, 2024
Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
Copy link

sonarcloud bot commented Mar 20, 2024

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dislbenn dislbenn closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants