-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor simulator drivers #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisermann
force-pushed
the
async-simulator
branch
from
December 27, 2018 15:53
2911f9a
to
8e9bbb5
Compare
kaisermann
changed the title
[WIP] Make the simulator boot asynchronous
[WIP] Refactor simulator drivers
Dec 27, 2018
kaisermann
force-pushed
the
async-simulator
branch
from
December 27, 2018 17:48
8aeb21c
to
be754ab
Compare
kaisermann
changed the title
[WIP] Refactor simulator drivers
Refactor simulator drivers
Dec 27, 2018
Pedroglp
approved these changes
Jan 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esse PR começou de um jeito e acabou de outro. Não faz muito sentido "assincronizar" o simulador por agora e só traria complicações nos testes. O PR se resume em uma refatoração dos drivers e plugins internos do simulador para usar o immer.js