Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/typescript integration #19

Merged

Conversation

NemeSnz
Copy link
Contributor

@NemeSnz NemeSnz commented Nov 9, 2020

What does this PR do?

  • Migrate javascript code to typescript
  • Add prepare npm script to compile to javascript
  • Change module entry point to dist/uplink.js

Related Issues

#18

@kmozurkewich
Copy link
Member

@NemeSnz - thank you for this submission. We will review over the next few days and provide any feedback.

@ayush-srivastava-03
Copy link
Member

Hello @NemeSnz we are currently reviewing PR submitted by you. We will update you shortly.

@NemeSnz
Copy link
Contributor Author

NemeSnz commented Nov 24, 2020

Hi @ayush-srivastava-03, feel free to reach me if you need to discuss anything related to this PR

@ayush-srivastava-03
Copy link
Member

Hi @NemeSnz , please check and merge the pull request created .

@kmozurkewich kmozurkewich merged commit 35e4dc3 into storj-thirdparty:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants