add dlerror() information #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mniewrzal
reviewed
Jul 1, 2022
mniewrzal
previously approved these changes
Jul 5, 2022
egonelbre
reviewed
Jul 19, 2022
egonelbre
previously approved these changes
Jul 20, 2022
When the uplink library cannot be loaded, there is currently a generic message originating from PHP. This is in all PHP versions. This change adds extra information which will help the user diagnose the issue. Example of old output: Fatal error: Uncaught FFI\Exception: Failed loading '/app/build/libuplink-x86_64-linux.so' in /app/src/Uplink.php:42 Example of new output: Fatal error: Uncaught FFI\Exception: Failed loading '/app/build/libuplink-x86_64-linux.so'. /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /app/build/libuplink-x86_64-linux.so) in /app/src/Uplink.php:60 Fixes #21
|
Did |
egonelbre
approved these changes
Jul 20, 2022
mniewrzal
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the uplink library cannot be loaded, there is currently a generic
message originating from PHP. This is in all PHP versions.
This change adds extra information which will help the user diagnose the
issue.
Example of old output:
Example of new output:
Fixes #21