-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(solid, solid-vite): preset.js: module is not defined
#19
base: main
Are you sure you want to change the base?
Conversation
JellyBrick
commented
Jan 8, 2025
- ref fix: preset.js is esm (node 22.12.0) addon-webpack5-compiler-swc#11
If executed on Node.js version 22.x.x, the same error occurs. In the 20.x.x version, it runs without any errors. |
@bichikim Curiously, this problem only appears when Node.js has its experimental support for |
After |
Indeed, I'm also aware of this after I commented, BTW it's v22.12.0, not v22.10.0. Hope the PR got merged and a new beta is released. |
@JonahPlusPlus Could you check this PR? |
It seems fine (still gonna test it locally to verify the build output), but when comparing it to the Storybook repo, I noticed they are still using the require syntax. Does Storybook for React still work? Could I get a QRD of any PRs on that side? (I want to make sure this project is consistent with practices on the main repo) |
This also should change the |