-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add databases repos #1145
Closed
Closed
Add databases repos #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74133f5
to
b048b01
Compare
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
- Coverage 12.75% 12.32% -0.44%
==========================================
Files 199 206 +7
Lines 4571 4805 +234
Branches 724 748 +24
==========================================
+ Hits 583 592 +9
- Misses 3347 3549 +202
- Partials 641 664 +23
Continue to review full report at Codecov.
|
659d0d6
to
5a34d35
Compare
Unsurprisingly, the comments addon does not currently work. See #1190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
ADD 2 more misc repos:
lib/database & lib/database-local
I'm not sure what these are for and wether we want to continue working with / on them.
Addon comments uses this for persistence, but I guess any addon could want persistence..
How to test
run unit tests