Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add databases repos #1145

Closed
wants to merge 46 commits into from
Closed

Add databases repos #1145

wants to merge 46 commits into from

Conversation

ndelangen
Copy link
Member

Issue:

What I did

ADD 2 more misc repos:
lib/database & lib/database-local

I'm not sure what these are for and wether we want to continue working with / on them.

Addon comments uses this for persistence, but I guess any addon could want persistence..

How to test

run unit tests

@ndelangen ndelangen force-pushed the add-databases-repos branch from 74133f5 to b048b01 Compare May 28, 2017 20:54
@codecov
Copy link

codecov bot commented May 28, 2017

Codecov Report

Merging #1145 into master will decrease coverage by 0.43%.
The diff coverage is 5.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1145      +/-   ##
==========================================
- Coverage   12.75%   12.32%   -0.44%     
==========================================
  Files         199      206       +7     
  Lines        4571     4805     +234     
  Branches      724      748      +24     
==========================================
+ Hits          583      592       +9     
- Misses       3347     3549     +202     
- Partials      641      664      +23
Impacted Files Coverage Δ
lib/database-local/src/shared/database.js 0% <0%> (ø)
lib/database-local/src/server/middleware.js 0% <0%> (ø)
lib/database-local/src/client/bundledPersister.js 0% <0%> (ø)
...ib/database-local/src/client/devServerPersister.js 0% <0%> (ø)
lib/database-local/src/client/index.js 0% <0%> (ø)
lib/database/dist/index.js 0% <0%> (ø)
lib/database/src/index.js 100% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe882f9...5a34d35. Read the comment docs.

@ndelangen ndelangen force-pushed the add-databases-repos branch from 659d0d6 to 5a34d35 Compare May 28, 2017 21:11
@ndelangen ndelangen added this to the v3.1.0 milestone Jun 2, 2017
@tmeasday
Copy link
Member

tmeasday commented Jun 6, 2017

Unsurprisingly, the comments addon does not currently work. See #1190

@ndelangen ndelangen closed this Jun 9, 2017
@ndelangen ndelangen deleted the add-databases-repos branch September 21, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants