Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artsy to examples documentation #1235

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Add artsy to examples documentation #1235

merged 1 commit into from
Jun 9, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 9, 2017

Issue: N/A

What I did

Add artsy to examples documentation

localhost_8000_examples_

How to test

if you must:

cd docs
yarn install
yarn dev
open http://localhost:8000/examples/

@orta
Copy link
Member

orta commented Jun 9, 2017

Perfect

@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Jun 9, 2017
@shilman shilman merged commit f49004d into master Jun 9, 2017
@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #1235 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1235   +/-   ##
=======================================
  Coverage   13.74%   13.74%           
=======================================
  Files         207      207           
  Lines        4633     4633           
  Branches      504      577   +73     
=======================================
  Hits          637      637           
+ Misses       3565     3493   -72     
- Partials      431      503   +72
Impacted Files Coverage Δ
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/init.js 0% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 41.66% <0%> (ø) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e99a3...f338342. Read the comment docs.

artsy:
thumbnail: ./thumbnails/artsy.png
title: Artsy Force
description: Arty's "Force" component library
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small spelling error here, should be Artsy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh. thanks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for featuring us!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Thanks for using and contributing to Storybook!

@shilman shilman deleted the add-artsy-example branch June 9, 2017 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants