Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step for import addon-action to addons.js file before start using it #1327

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

natsathorn
Copy link
Contributor

Issue: When I try using Storybook I was following the step in this repository but it has no step that told me to import addon-action to addons.js file. So, I've spend a lot of time to find out why I have no action logger

What I did

Add the step that told user to import @storybook/addon-actions/register to addons.js before start using action on components

How to test

Nothing to test, MD file will break nothing.

@codecov
Copy link

codecov bot commented Jun 21, 2017

Codecov Report

Merging #1327 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
  Coverage   13.76%   13.76%           
=======================================
  Files         201      201           
  Lines        4620     4620           
  Branches      506      503    -3     
=======================================
  Hits          636      636           
- Misses       3543     3557   +14     
+ Partials      441      427   -14
Impacted Files Coverage Δ
lib/components/src/demo/Welcome.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/WrapStory.js 12% <0%> (ø) ⬆️
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/client_api.js 39.28% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 38.57% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.94% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
app/react/src/server/build.js 0% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b975fc3...62b2651. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@shilman shilman merged commit 2c54e27 into storybookjs:master Jun 21, 2017
@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants