Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Refactor ProgressPlugin handling #14016

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Core: Refactor ProgressPlugin handling #14016

merged 2 commits into from
Feb 22, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 22, 2021 •
edited
Loading

Issue: #14007

What I did

There was a webpack version conflict that I patched over in #14007

This is a more proper fix. Now:

  • the useProgressReporting hook is no longer dependency-injected (why was it?!)
  • the useProgressReporting hook returns the values needed to construct a ProgressPlugin
  • each builder is responsible for constructing its own ProgressPlugin

How to test

  • CI passes
  • Update builder: 'webpack5' in examples/react-ts

@shilman shilman added the bug label Feb 22, 2021
@shilman shilman merged commit 6a8f302 into next Feb 22, 2021
@shilman shilman deleted the 14007-refactor-progress-plugin branch February 22, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

Assignees
No one assigned
Labels
bug builder-webpack5 core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @ndelangen