-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop add-on Draggable from overlapping the vertical scrollbar when stories overflow #17663
Stop add-on Draggable from overlapping the vertical scrollbar when stories overflow #17663
Conversation
…flow at the bottom, making the story unscrollable
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e962b47. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
hey @LucaCras thanks a lot for your contribution! There's a minor detail (which we discussed in triage) so let us know if you can revisit that and if you ever want assistance feel free to ping! |
I am happy to help with anything design-related. I could do some ideation and propose a few things if you prefer. |
… scrollbar & iframe
Hi @MichaelArestad, I have made a change that fixes the shadow to show up on the left side, instead of right, I have uploaded a video in the original message. Can you check if this works? I have also added a 1px margin, so there is no overlap between the iframe and the panel / draggable handle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LucaCras This is quite nice. Nice work!
Thanks! Is there anything else I need to do @MichaelArestad? |
@LucaCras I don't think so. This is just awaiting merge. |
Issue: #17202
fix the draggable overlaying the vertical scrollbar when stories overflow at the bottom, making the story un-scrollable.
What I did
There was a negative margin on the Draggable component that is responsible for resizing the add-on panel when in side-panel mode.
This margin pushed the Draggable to the left by 10px, which caused it to overlap with the vertical scrollbar for scrolling down a long story.
I have removed this margin, which puts the Draggable in the correct spot.
Below is an image illustrating the old- (yellow) & new (blue) positions.
Schermopname.2022-03-16.om.16.16.38.mov
How to test
If your answer is yes to any of these, please make sure to include it in your PR.