-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contribute/framework
doc
#19943
Add contribute/framework
doc
#19943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Historically, people have wanted to contribute frameworks directly to the monorepo--I wonder if this doc should somehow preempt that.
I also wonder about a step on distributing the framework, e.g. tweet and mention @storybookjs
. Or if the pattern described here will automatically get picked up by the integrations catalog, mention that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kylegach, this looks great. Just left a couple of items for you to look at. Let me know if you're ok with it, and we'll go from there also while we're at it. It seems that you left out the toc.js entry so we can hook this up to the documentation. Was this intentional or not?
- Add bits about announcing and path to "official" status
- Add link to TOC - Change 'Write the README' heading to 'Write the documentation" - Remove 'Thank you' section - Add 'Other ways to contribute' section - Update/add corresponding section on other relevant pages
98ebd68
to
316e37e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of the feedback so promptly @kylegach! Appreciate it. All good on my end! Merge when able
What I did
Add a page at the
/docs/<framework>/contribute/framework
route explaining how to contribute a Storybook framework