add addon background to monorepo #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielduan
reviewed
Nov 2, 2017
|
|
||
| ### Development | ||
|
|
||
| This project is built using typescript and is tested with jest. To get started, clone this repo and run the following command: |
There was a problem hiding this comment.
good point, will remove it. No we removed the typescript.
Codecov Report
@@ Coverage Diff @@
## master #2220 +/- ##
==========================================
+ Coverage 21.48% 22.16% +0.67%
==========================================
Files 263 268 +5
Lines 5804 5875 +71
Branches 693 706 +13
==========================================
+ Hits 1247 1302 +55
- Misses 4023 4038 +15
- Partials 534 535 +1
Continue to review full report at Codecov.
|
ndelangen
changed the title
…ooks/storybook into ndelangen/import-addon-background
Hypnosphi
reviewed
Nov 4, 2017
addons/background/src/index.story.js
Outdated
| @@ -0,0 +1,19 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Looks like this file isn't used, I'll delete it
Hypnosphi
reviewed
Nov 4, 2017
| @@ -0,0 +1,17 @@ | |||
| import React from 'react'; | |||
Hypnosphi
approved these changes
Nov 4, 2017
Hypnosphi
reviewed
Nov 5, 2017
| getQueryParam: PropTypes.func, | ||
| setQueryParams: PropTypes.func, | ||
| }).isRequired, | ||
| channel: PropTypes.instanceOf(EventEmitter), |
There was a problem hiding this comment.
This fails in cra-kitchen-sink (probably because of different events package version):
manager.bundle.js:6219 Warning: Failed prop type: Invalid prop `channel` of type `Channel` supplied to `BackgroundPanel`, expected instance of `EventEmitter`
Let's use PropTypes.shape, like we do in other plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: storybook-eol/addon-backgrounds#36
What I did
lerna importHow to test