-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storybook CLI for angular: dev dependencies and fix addon-notes usage #2572
Conversation
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2572 +/- ##
=======================================
Coverage 32.68% 32.68%
=======================================
Files 398 398
Lines 8838 8838
Branches 942 966 +24
=======================================
Hits 2889 2889
+ Misses 5304 5257 -47
- Partials 645 692 +47
Continue to review full report at Codecov.
|
'@storybook/addon-notes', | ||
'@storybook/addon-actions', | ||
'@storybook/addon-links', | ||
'@types/lodash-es' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still needed, given that we've reverted #2558 ?
Issue: #2569
What I did
How to test
Is this testable with jest or storyshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.