Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Patch 8.4.5 #29625

Merged
merged 13 commits into from
Nov 20, 2024
Merged

Release: Patch 8.4.5 #29625

merged 13 commits into from
Nov 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 15, 2024

This is an automated pull request that bumps the version from 8.4.4 to 8.4.5.
Once this pull request is merged, it will trigger a new release of version 8.4.5.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: CLI: Fix qwik init #29632
  • 🐛 Bug: CLI: Disable corepack auto pin behavior #29627
  • ✨ Feature Request: Nextjs-Vite: Add Next.js 15 support #29640
  • ✨ Feature Request: Angular: Support v19 #29659
  • 📝 Documentation: Docs: Svelte CSF snippets #29546
  • 📝 Documentation: Docs: Minor fixes to Svelte CSF #29628
  • 📝 Documentation: Improve Documentation clarity of Vite Framework limitations for test-addon #29629
  • 📝 Documentation: Docs: Update chromatic-install.md #29547

🍒 Manual cherry picking needed!

The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.

  • #29627: git cherry-pick -m1 -x b2f3fc990b7bf512a70c2e23f6645b384d3010e6

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.4.5

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Nov 15, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

105 file(s) reviewed, 85 comment(s)
Edit PR Review Bot Settings | Greptile

docs/_snippets/button-group-story.md Show resolved Hide resolved
docs/_snippets/button-group-story.md Outdated Show resolved Hide resolved
docs/_snippets/button-story-component-decorator.md Outdated Show resolved Hide resolved
docs/_snippets/button-story-component-decorator.md Outdated Show resolved Hide resolved
docs/get-started/frameworks/sveltekit.mdx Outdated Show resolved Hide resolved
docs/get-started/whats-a-story.mdx Show resolved Hide resolved
docs/writing-stories/decorators.mdx Outdated Show resolved Hide resolved
docs/writing-stories/index.mdx Outdated Show resolved Hide resolved
docs/writing-stories/parameters.mdx Show resolved Hide resolved
@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.4 branch 2 times, most recently from 8467ffa to 8be1f17 Compare November 16, 2024 06:17
@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.4 branch 2 times, most recently from d75b3ea to aba1cd2 Compare November 17, 2024 06:20
@github-actions github-actions bot changed the title Release: Merge patches to main (without version bump) Release: Patch 8.4.5 Nov 17, 2024
@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.4 branch 4 times, most recently from f95fb7a to b8451d3 Compare November 18, 2024 21:27
@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.4 branch 2 times, most recently from 4e9d88c to 895b6c2 Compare November 19, 2024 12:37
@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.4 branch 2 times, most recently from 9fd2b84 to c9c8e05 Compare November 19, 2024 23:15
@shilman shilman added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Nov 20, 2024
Copy link

nx-cloud bot commented Nov 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fb1da8c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@yannbf yannbf removed the freeze Freeze the Release PR with this label label Nov 20, 2024
jonniebigodes and others added 3 commits November 20, 2024 12:01
…s_v5

Docs: Svelte CSF snippets
(cherry picked from commit c7569a6)
…lte_csf

Docs: Minor fixes to Svelte CSF
(cherry picked from commit 2719b7e)
Improve Documentation clarity of Vite Framework limitations for test-addon

(cherry picked from commit 2f8a586)
shilman and others added 5 commits November 20, 2024 12:01
CLI: Fix qwik init
(cherry picked from commit 6f0f798)
Docs: Update chromatic-install.md
(cherry picked from commit 487d2cb)
Nextjs-Vite: Add Next.js 15 support
(cherry picked from commit 9794e35)
Angular: Support v19
(cherry picked from commit fa3cf88)
@yannbf yannbf added the freeze Freeze the Release PR with this label label Nov 20, 2024
…issue

CLI: Disable corepack auto pin behavior
(cherry picked from commit b2f3fc9)
@yannbf yannbf merged commit dba1f48 into latest-release Nov 20, 2024
104 of 105 checks passed
@yannbf yannbf deleted the version-patch-from-8.4.4 branch November 20, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants