Generic addon decorators #3555
Merged
Generic addon decorators #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
added
in progress
addon: knobs
maintenance
Hypnosphi
requested review from
alexandrebodin,
alterx,
igor-dv,
jbovenschen,
leonrodenburg,
ndelangen,
shilman,
stijnkoopal,
theinterned and
tmeasday
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3555 +/- ##
=========================================
- Coverage 37.08% 36.49% -0.6%
=========================================
Files 511 487 -24
Lines 10851 10265 -586
Branches 975 944 -31
=========================================
- Hits 4024 3746 -278
+ Misses 6227 5941 -286
+ Partials 600 578 -22
Continue to review full report at Codecov.
|
Hypnosphi
commented
May 7, 2018
| @@ -1 +1 @@ | |||
| module.exports = require('./dist/mithril'); | |||
| module.exports = require('./dist/deprecated'); | |||
There was a problem hiding this comment.
I think we can keep those files for one alpha release
|
@storybooks/team it's ready for final review |
…ators # Conflicts: # addons/viewport/package.json
wuweiweiwu
approved these changes
May 15, 2018
…ators # Conflicts: # ADDONS_SUPPORT.md # examples/angular-cli/src/stories/__snapshots__/custom-styles.stories.storyshot
shilman
removed
the
cleanup
|
Released as |
This was referenced Nov 1, 2018
This was referenced Dec 1, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on decorators for
storybook/html