-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel 7 #3746
Merged
Babel 7 #3746
Changes from 26 commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
c704d60
Initial move to babel 7
Hypnosphi 69cc530
Merge remote-tracking branch 'origin/master' into babel-7
Hypnosphi cb988d0
Move lib/core to babel@7
Hypnosphi a4f9a2e
Move back to .babelrc
Hypnosphi 084671c
Fix lint error
Hypnosphi 113c182
Merge master
Hypnosphi 73dc63b
Update dependencies
Hypnosphi b6153d1
Merge master
Hypnosphi 0f93c5e
Add @babel/runtime dependency to all the packages with server-side part
Hypnosphi ee5c7c7
Update dependencies
Hypnosphi 720bb23
Migration guide
Hypnosphi e496dfb
Update CLI
Hypnosphi 87312a6
Fix vue build
Hypnosphi a050bcb
Update lockfile
Hypnosphi 74475b9
Fix jest
Hypnosphi c4e468a
Fix jest
Hypnosphi ee6472d
Fix RN test
Hypnosphi 170160d
Revert CLI changes for RN
Hypnosphi 3c0e383
Add babel-loader peer dep
Hypnosphi 6da0f7a
Commit snapshot
Hypnosphi 4b169ab
Fix version choice logic
Hypnosphi ba544ef
Merge branch 'master' into babel-7
ndelangen d0b7972
FIX snapshots
ndelangen e0ad03d
Merge branch 'master' into babel-7
ndelangen a87d16d
FIX snapshots
ndelangen 0ec2bc0
REMOVE smoke-tests in cli (static build examples are now all in teamc…
ndelangen 6371e1f
Merge branch 'master' into babel-7
ndelangen a039c96
Merge branch 'master' into babel-7
ndelangen 6e2d8c1
UPDATE "babel-plugin-react-docgen": "^2.0.0-babel7.0",
ndelangen a8e41c9
REVERT incorrect removal of package relating to angular
ndelangen fe86390
REMOVE unneeded tslint config
ndelangen e6c055c
FIX snapshots
ndelangen bf3c2e5
UPGRADE to babel7-rc.1
ndelangen b649f24
REMOVE stage presets and replace with plugins we need
ndelangen f7cd337
FIX eslint
ndelangen 9a1abf2
FIX cli-tests
ndelangen 3ae34e5
FIX cli test snapshots
ndelangen 850b083
FIX angular example with a hack?
ndelangen 1209703
REVERT changes to angular require-context (BROKEN)
ndelangen 7ed57a8
FIX a warning in polymer storybook
ndelangen 04f6ef8
Fix jest-ts-babel.js
igor-dv 3c027a4
Try to fix CLI
igor-dv 41d6168
CHANGE tot use babel7 everywhere (not just for our own build, but als…
ndelangen 29e1c02
SORT package.json files
ndelangen 107f5e0
FIX cli snapshots
ndelangen f627592
FIX incorrect dependency in app/html
ndelangen 2b4f05b
FIX lockfile
ndelangen f36869a
TEMP FIX for hyperapp in netlify
ndelangen df723e0
REVERT deletion of smoke tests on cli output && REVERT babel6 cli fix…
ndelangen 61d5c09
REVERT version-change for react in app/html
ndelangen 224e1f9
UPDATE react & react-dom for app/svelte
ndelangen aadd8f0
CHANGE the installBabel to only install babel-loader & RENAME to inst…
ndelangen 4fcf8cb
FIX snapshots
ndelangen 3dec3ba
FIX lockfile
ndelangen 5b9226b
CHANGE docs for migrating to babel 7
ndelangen c6dd3e4
REMOVE unneeded dependency
ndelangen 773821d
CHANGE cli tests to e2e
ndelangen bfccae4
FIX package.json
ndelangen bbf7d8a
no message
ndelangen 30fe991
FIX package.json in root version
ndelangen 7b5dc84
FIX verdaccio.yaml
ndelangen 40274f9
FIX cli/run_tests to install for each run individually
ndelangen 165e996
FIX so tests are run in correct folder
ndelangen cb69d42
FIX so legacy packages *are* proxied
ndelangen 305fff1
FIX webpack-react cli example
ndelangen f8332e7
CHANGE meteor generator babel file
ndelangen c0cd951
REMOVE the babel-root-slash-import module completely. It's not used b…
ndelangen 7102951
Merge branch 'master' into babel-7
ndelangen 451b8af
CHANGE teamcity config to test cli e2e via new script
ndelangen a05565b
UPGRADE to rc.2
ndelangen 72e4b84
REVERT ci tests for ci via yarn test --cli
ndelangen ad78be3
CHANGE to silent installs during e2e
ndelangen 70d9094
CHANGE to fixed version, otherwise they keep changing when testing
ndelangen 2028cd4
Removed the added @babel/core everywhere
pksunkara 94a049c
Revert "CHANGE the installBabel to only install babel-loader & RENAME…
pksunkara f1cf6d2
Remove unnecessary babel bridge installation in installBabel
pksunkara 9c4cff4
Use installBabel for meteor cli
pksunkara 9648d20
FIX scripts/test.js
ndelangen bb3e725
Pass registry url to lerna
pksunkara 961fdef
Fixed cli test issues
pksunkara 36a2676
Cleanup not needed anymore
Hypnosphi 489d55d
Added babel-loader to app/svelte
pksunkara 06d799c
Use 'babel-loader' without "require.resolve"
igor-dv c5f5433
Try to bring the CLI back
igor-dv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,34 @@ | ||
{ | ||
"presets": ["env", "stage-0", "react"], | ||
"env": { | ||
"test": { | ||
"plugins": ["require-context-hook"] | ||
}, | ||
"plugins": [ | ||
"emotion", | ||
"babel-plugin-macros", | ||
["transform-runtime", { | ||
"presets": [ | ||
"@babel/preset-env", | ||
["@babel/preset-stage-0", { "decoratorsLegacy": true }], | ||
"@babel/preset-react", | ||
"@babel/preset-flow" | ||
], | ||
"plugins": [ | ||
"babel-plugin-emotion", | ||
"babel-plugin-macros", | ||
[ | ||
"@babel/plugin-transform-runtime", | ||
{ | ||
"polyfill": false, | ||
"regenerator": true | ||
}] | ||
} | ||
] | ||
} | ||
], | ||
"env": { | ||
"test": { | ||
"plugins": ["babel-plugin-require-context-hook"] | ||
} | ||
}, | ||
"overrides": [ | ||
{ | ||
"test": "./examples/vue-kitchen-sink", | ||
"presets": [ | ||
"@babel/preset-env", | ||
["@babel/preset-stage-0", { "decoratorsLegacy": true }], | ||
"babel-preset-vue" | ||
] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,8 @@ | |
- [Removed addWithInfo](#removed-add-with-info) | ||
- [Removed RN addons](#removed-rn-addons) | ||
- [Storyshots changes](#storyshots-changes) | ||
- [Webpack 4](#webpack-4) | ||
- [Babel 7](#babel-7) | ||
- [From version 3.3.x to 3.4.x](#from-version-33x-to-34x) | ||
- [From version 3.2.x to 3.3.x](#from-version-32x-to-33x) | ||
- [Refactored Knobs](#refactored-knobs) | ||
|
@@ -54,6 +56,20 @@ will need to add a babel plugin to polyfill this functionality. | |
A possible plugin might be [babel-plugin-require-context-hook](https://github.com/smrq/babel-plugin-require-context-hook). | ||
[README](https://github.com/storybooks/storybook/tree/master/addons/storyshots/storyshots-core#configure-jest-to-work-with-webpacks-requirecontext) | ||
|
||
### Webpack 4 | ||
|
||
Storybook now uses webpack 4. If you have a [custom webpack config](https://storybook.js.org/configurations/custom-webpack-config/), make sure that all the loaders and plugins you use support webpack 4. | ||
|
||
### Babel 7 | ||
|
||
Storybook now uses Babel 7. There's a couple of cases when it can break with your app: | ||
|
||
* If you aren't using Babel yourself, and don't have .babelrc, install following dependencies: | ||
``` | ||
npm i -D babel-core@bridge @babel/core babel-loader@next | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. now it's only babel-loader. And it may also be needed for those that use Babel without webpack There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
``` | ||
* If you're using Babel 6, make sure that you have direct dependencies on `babel-core@6` and `babel-loader@7`. | ||
|
||
## From version 3.3.x to 3.4.x | ||
|
||
There are no expected breaking changes in the 3.4.x release, but 3.4 contains a major refactor to make it easier to support new frameworks, and we will document any breaking changes here if they arise. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this no longer exists on RC versions
https://babeljs.io/blog/2018/07/27/removing-babels-stage-presets