-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use babelrc: false
only for custom config in .storybook
directory
#4077
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4077 +/- ##
=======================================
Coverage 40.52% 40.52%
=======================================
Files 467 469 +2
Lines 5636 5636
Branches 747 745 -2
=======================================
Hits 2284 2284
- Misses 2982 2984 +2
+ Partials 370 368 -2
Continue to review full report at Codecov.
|
@@ -17,27 +15,3 @@ storiesOf('Addons|Knobs/Hello', module) | |||
age, | |||
}); | |||
}); | |||
|
|||
storiesOf('Addons|Knobs/Hello (Marko Widget)', module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no widgets in a new version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they decided to drop this functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @nm123github
} | ||
|
||
return babelConfig || defaultConfig; | ||
return isBabelLoader8() ? defaultConfig : {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, our default babel config is for babel8. After removing babelrc: false
, can't we just return the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, just understood my mistake 🤦♂️
BTW, by
You mean we can get rid of |
@@ -19,8 +19,7 @@ | |||
}, | |||
"dependencies": { | |||
"marko": "^4.12.4", | |||
"marko-starter": "^2.0.4", | |||
"marko-widgets": "^7.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why delete the widgets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are deprecated and don't support marko 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, clear!
No, it means that our default config is now being merged with user's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, this makes so much sense!
Fixes #2582 #2771 #2610 #754 #2635
This also removes the need to duplicate our presets (react, env etc) in user's app babel config