Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onDeviceUI] Add ability to render addons in React Native #4381

Merged
merged 103 commits into from
Oct 12, 2018
Merged

[onDeviceUI] Add ability to render addons in React Native #4381

merged 103 commits into from
Oct 12, 2018
+1,047 −288

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Oct 12, 2018

I forgot to change base branch before on merging #3903 . This PR is to merge that branch into the master.

Gongreg added 30 commits July 19, 2018 17:38
@Gongreg
Reducing the size of the ui.
8bf63f5
@Gongreg
Addon scrollview with addon names
2a6fe0f
@Gongreg
Updated style, shows addons list with loaded addons.
233f369
@Gongreg
Updated status bar, so content would not be drawn below it on android.
f745fdb
@Gongreg
Added some addons to example.
676c110
@Gongreg
Moved out of state
dc3b8a4
@Gongreg
Fixed event on android.
07b502d
@Gongreg
Temporary disabled yellow box.
a8af427
@Gongreg
Adding two options for storybook ui:
e5ca681 
isUIOpen - whether to initially show top bar - default true.
isStoryMenuOpen - should show story menu open by default - default false.
@Gongreg
Creating rn-addons.js file inside generators.
8d31f83
@Gongreg
Removed separate addon store.
838748e
@Gongreg
Using active prop.
d62e440
@Gongreg
Rewrote addons wrapper without using modal.
cd0f98a 
We cannot use modal since addons expect to be rendered all the time.
So now we display the wrapper as position absolute and make it 0 0 size when it is not visible.
@Gongreg
Fixing yellow box warnings.
20969ec
@Gongreg
Addon window by default is scrollable.
21d19c2
@Gongreg
Removed yellow box disabling, cleared up example index.
6215c8e
@Gongreg
Reverted accidentally deleted line.
33c99ab
@Gongreg
Updated dependencies.
40007cf
@Gongreg
Dependency bump
5a9e6ff
@Gongreg
Updated UI. Removed modal, displaying menus as panels appearing from …
15f48af 
…sides.
@Gongreg
Clearing up the style a little bit.
ab3cacd
@Gongreg
fixed merge conflict
882cf00
@Gongreg
Temporary disabling some examples
1fca1dc
@Gongreg
Updating the readmes.
e383470
@Gongreg
Updating the readme.
05c96f0
@Gongreg
Added notes addon that support rn
cd957da
@Gongreg
Updated addon documentation regarding setTimeout.
b1d1d5f
@Gongreg
Fixed proptypes issue, properly set initial tab from the props.
ff66452
@Gongreg
Reduced the amount of rerenders, if you use onDeviceUI it only listen…
9722c17 
…s to story change events once instead of twice.
@Gongreg
Adding more addons.
dd1fc34
Gongreg and others added 15 commits October 9, 2018 11:24
@Gongreg Gongreg merged commit e413ec2 into master Oct 12, 2018
@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

This was referenced Nov 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2018
Open
Open
Open
@ndelangen ndelangen deleted the on-device-ui-all-prs branch May 7, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielduan danielduan Awaiting requested review from danielduan

@rmevans9 rmevans9 Awaiting requested review from rmevans9

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gongreg @storybook-safe-bot @ndelangen